Add contributors image generation action#4
Conversation
|
@skyash-dev i appreciate you doing this, not a maintainer but a fellow contributor. Here are following points which i noticed on your code:
What this means in practice:
|
NalinDalal
left a comment
NalinDalal
left a comment
There was a problem hiding this comment.
Work can be more optimised for redundancy and other things.
| const buffer = Buffer.from(await res.arrayBuffer()); | ||
| return await loadImage(buffer); | ||
| } catch (err) { | ||
| return null; |
There was a problem hiding this comment.
Silent failure (return null) may result in missing avatars without visibility. Consider logging failures (at least debug level) to help diagnose broken avatar URLs.
There was a problem hiding this comment.
i have tested the workflow multiple times and all images are successfully fetched consistently. and if in some case any fails, keeping that blank is a good default i think?
|
@NalinDalal thank you for the review. funny how almost all fixes trace back to the same underlying issue (missing a comparison between contentBuffer and the existingBuffer). |
2 participants
#1
This introduces a reusable github action that generates a contributors image from the
.all-contributorsrcfile.what it does:
implementation details:
tests:
GITHUB_TOKENmust be configured with the appropriate workflow permissions: